Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: remove timing from golden lhr #5020

Merged
merged 4 commits into from
Apr 23, 2018
Merged

misc: remove timing from golden lhr #5020

merged 4 commits into from
Apr 23, 2018

Conversation

paulirish
Copy link
Member

No description provided.

patrickhulce
patrickhulce approved these changes Apr 23, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

brendankenny
brendankenny approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Though will we run into an issue with sample_v2.json not being a real LHR?

The other option is something worse to write where update:sample-json only replaces the file if it's different according to diff:sample-json :)

@paulirish paulirish merged commit 4276e6e into master Apr 23, 2018
@paulirish paulirish deleted the goldenlhr-notiming branch April 23, 2018 20:29
kdzwinel pushed a commit to kdzwinel/lighthouse that referenced this pull request Aug 16, 2018
@paulirish @kdzwinel
misc: remove timing from golden lhr (GoogleChrome#5020)
d21fdc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulirish @brendankenny @patrickhulce @devtools-bot