Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report(table): handle null cells #5075

Merged
merged 1 commit into from
May 1, 2018
Merged

report(table): handle null cells #5075

merged 1 commit into from
May 1, 2018

Conversation

patrickhulce
Copy link
Collaborator

just bumped into a case where the report failed to render entirely because a value was null in the JSON (presumably because the value was NaN on the node side and was stringified into null by the time it was injected into the renderer)

@paulirish paulirish merged commit 25f920e into master May 1, 2018
@paulirish paulirish deleted the misc_null_fix branch May 1, 2018 00:08
kdzwinel pushed a commit to kdzwinel/lighthouse that referenced this pull request Aug 16, 2018
@patrickhulce @kdzwinel
report(table): handle null cells (GoogleChrome#5075)
b0d6a70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny

@vinamratasingal-zz vinamratasingal-zz Awaiting requested review from vinamratasingal-zz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickhulce @paulirish