core(lhr): audit id, title, description #5190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
requested review from
brendankenny,
paulirish and
vinamratasingal-zz
as code owners
brendankenny
approved these changes
May 12, 2018
| @@ -184,18 +184,19 @@ class Audit { | |||
| } | |||
|
|
|||
| return { | |||
| id: audit.meta.name, | |||
| title: auditDescription, | |||
There was a problem hiding this comment.
rename local auditDescription to auditTitle or whatever?
Is this just in meta objects or is it more than that? |
paulirish
approved these changes
May 12, 2018
mostly just in meta objects but it touches every audit and a few places that consume direct from meta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phase 1 of audit property renames, this PR changes the LHR property names but not the source ones in the audits (we can do that piecemeal if need be since that'll be huge)