tests(viewer): upgrade pptr to handle new CSSOM use in the report #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
requested review from
ebidel,
paulirish and
vinamratasingal-zz
as code owners
ebidel
approved these changes
May 11, 2018
|
|
||
| // Rethrow to make sure it's auditable as an error. | ||
| setTimeout(_ => { | ||
| throw new Error(msg); |
There was a problem hiding this comment.
Why the settimeout?
it's a hack that lets logger catch it so the report still acts nicely (with a toast) even if the report is invalid or whatever, but now it also async throws the error so that the problem can be picked up in the console and (more importantly) in the puppeteer pageerror listener we add in the test :)
There was a problem hiding this comment.
added to the comment to clarify
| @@ -97,7 +97,7 @@ | |||
| "npm-run-posix-or-windows": "^2.0.2", | |||
| "nyc": "^11.6.0", | |||
| "postinstall-prepare": "^1.0.1", | |||
| "puppeteer": "^1.1.1", | |||
| "puppeteer": "1.4.0", | |||
There was a problem hiding this comment.
Should the version be more flexible?
There was a problem hiding this comment.
Should the version be more flexible?
I have no strong feelings, but with the yarn.lock file we pretty much have to manually rev anyways, so not sure if it matters
paulirish
approved these changes
May 11, 2018
| @@ -66,6 +66,10 @@ describe('Lighthouse Viewer', function() { | |||
| }); | |||
|
|
|||
| after(async function() { | |||
| // Log any page load errors encountered in case before() failed. | |||
| // eslint-disable-next-line no-console | |||
| console.log(pageErrors); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
computedStyleMapin the report fails in the Chromium version that our current version of puppeteer ships with. This revs the version so that we get a more recent Chromium.Drive by change to viewer and the viewer pptr test so that when there's an in-page error like this, the test can pick it up and print it to console instead of just timing out in
before()waiting for the report to load.