Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(response-compression): graceful recovery #5578

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

patrickhulce
Copy link
Collaborator

While testing out 3.0 I noticed quite a few response-compression errors, this will handle partial failure and beacon to sentry without failing the whole audit.

@paulirish paulirish added the 3.0 label Jul 17, 2018
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickhulce patrickhulce merged commit 9d43962 into master Jul 17, 2018
@patrickhulce patrickhulce deleted the recover_response_compression branch July 17, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants