Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(ttfb): reuse requestMainResource #5657

Merged
merged 2 commits into from
Jul 21, 2018
Merged

core(ttfb): reuse requestMainResource #5657

merged 2 commits into from
Jul 21, 2018

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Jul 11, 2018 •
edited
Loading

One of our top sentry errors is from TTFB not finding the right URL. It somehow hadn't moved to requestMainResource yet.

It's unclear why this started failing in 3.0 though...it should've been failing much earlier than that.

wardpeet
wardpeet approved these changes Jul 20, 2018
View reviewed changes
Copy link
Collaborator

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wardpeet wardpeet mentioned this pull request Jul 20, 2018
Closed
@GoogleChrome GoogleChrome deleted a comment from googlebot Jul 21, 2018
@paulirish paulirish merged commit 0265569 into master Jul 21, 2018
@paulirish paulirish deleted the ttfb_find_right_url branch July 21, 2018 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@wardpeet wardpeet wardpeet approved these changes

@brendankenny brendankenny Awaiting requested review from brendankenny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickhulce @paulirish @wardpeet