Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(i18n): sort the ICU messages when saved #5771

Merged
merged 3 commits into from
Aug 3, 2018
Merged

core(i18n): sort the ICU messages when saved #5771

merged 3 commits into from
Aug 3, 2018

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Aug 2, 2018 •
edited
Loading

the messages come back from TC sorted, so we should keep things sorted originally.

(i'll fix the conflicts when landing)

@paulirish paulirish added the i18n internationalization thangs label Aug 2, 2018
brendankenny
brendankenny approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to sort but this:

(i'll fix the conflicts when landing)

makes me nervous. Kind of thing that's the precursor to

2951dd50 - Fix i18n strings
1fb88sbf - fix i18n strings for real this time

:P

@paulirish paulirish merged commit b07552a into master Aug 3, 2018
@paulirish paulirish deleted the sortstrings branch August 3, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
i18n internationalization thangs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulirish @brendankenny