Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: depend on speedline-core, rather than the cli #5800

Merged
merged 2 commits into from
Aug 7, 2018
Merged

deps: depend on speedline-core, rather than the cli #5800

merged 2 commits into from
Aug 7, 2018

Conversation

paulirish
Copy link
Member

removes a few deps from yarn.lock

meow is no longer in the deps tree, though it does still get pulled in for devDeps via conventional-changelog-cli.

brendankenny
brendankenny approved these changes Aug 7, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! LGTM

@brendankenny
Copy link
Member

error is from also needing to update the speedline reference in artifacts.d.ts so the artifact is correctly be typed

@paulirish paulirish merged commit 87cce00 into master Aug 7, 2018
@paulirish paulirish deleted the speedlinecorebump branch August 7, 2018 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@patrickhulce patrickhulce Awaiting requested review from patrickhulce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulirish @brendankenny