tests(dbw): remove createShadowRoot call #5906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
commented
Aug 24, 2018
| @@ -10,17 +10,8 @@ | |||
|
|
|||
| const params = new URLSearchParams(location.search); | |||
|
|
|||
| if (location.search === '' || params.has('dateNow')) { | |||
| // FAIL - Date.now() usage in another file. | |||
| const d = Date.now(); | |||
There was a problem hiding this comment.
missed this when we deleted the audit
brendankenny
approved these changes
Aug 24, 2018
| // FAIL(errors-in-console) - multiple shadow v0 roots. | ||
| // TODO: disabled until m64 is stable (when moved from deprecation warning to error) | ||
| // div.createShadowRoot(); | ||
| window.webkitStorageInfo.PERSISTENT; // FAIL |
There was a problem hiding this comment.
maybe mark it as FAIL(deprecations)? (even though admittedly the params check is right up there :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master is failing again because of another canary change,
createShadowRootis going to be removed in M73, so I just swapped it for one of our other deprecations