Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(scoring): http2 redirect PWA score issue #5929

Merged

Conversation

adaschevici
Copy link
Contributor

…ails

Summary

Adds a note to the docs about a small issue in PWA scoring with simplehttp2server package.

This is a docs change.

It's required because it has been causing some issues and they are not being documented as known issues.

Related Issues/PRs

#1217
#5910

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@adaschevici adaschevici changed the title 5910: Add note to docs about PWA noscript failure on https redirect f… docs(adaschevici): add documentation note about http2 limitation Aug 29, 2018
@adaschevici adaschevici changed the title docs(adaschevici): add documentation note about http2 limitation docs(adaschevici): add docs http2 PWA score issue Aug 29, 2018
@adaschevici adaschevici changed the title docs(adaschevici): add docs http2 PWA score issue docs(adaschevici): http2 https redirect PWA score issue Aug 29, 2018
docs/scoring.md Outdated
@@ -57,6 +57,7 @@ Lighthouse has a whole section in the report on improving your performance score
# PWA
### How is the PWA score calculated?
The PWA score is calculated based on the [Baseline PWA checklist](https://developers.google.com/web/progressive-web-apps/checklist#baseline), which lists 14 requirements. Lighthouse tests for 11 out of the 14 requirements automatically, with the other 3 being manual checks. Each of the 11 audits for the PWA section of the report is weighted equally, so implementing any of the audits correctly will increase your overall score by ~9 points.
*Note: some metrics in this category have issues with https redirects because of TLS-handshake errors. More specifically you will run into this when using the ```simplehttp2server``` npm package. Subsequent metrics will fail after the https redirects(refs: #5910 & #5910) *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5910 repeated twice btw ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, copy-paste fail

@googlebot
Copy link

CLAs look good, thanks!

@paulirish paulirish changed the title docs(adaschevici): http2 https redirect PWA score issue docs(scoring): http2 redirect PWA score issue Sep 5, 2018
@paulirish paulirish merged commit 1bba64d into GoogleChrome:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants