Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: mv locale files #5981

Merged
merged 7 commits into from
Sep 21, 2018
Merged

i18n: mv locale files #5981

merged 7 commits into from
Sep 21, 2018

Conversation

paulirish
Copy link
Member

No description provided.

brendankenny
brendankenny reviewed Sep 8, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the move looks good, I think. Also great to move off of index.js

Test failure is in collect-strings.js, I think it's just this line needs to be updated:

lighthouse/lighthouse-core/scripts/i18n/collect-strings.js

Line 105 in 6656521

const fullPath = path.join(LH_ROOT, `lighthouse-core/lib/locales/${locale}.json`);

@brendankenny
Copy link
Member

need to merge/rebase. All sorts of weirdness going on with the file moves, I guess

@paulirish
Copy link
Member Author

ptal

brendankenny
brendankenny approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM/LGTM.js

@brendankenny brendankenny merged commit 7e969b2 into master Sep 21, 2018
@brendankenny brendankenny deleted the movelocales branch September 21, 2018 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

@patrickhulce patrickhulce Awaiting requested review from patrickhulce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulirish @brendankenny