Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: update score legend to match new threshold #5985

Merged
merged 3 commits into from
Sep 7, 2018

Conversation

zeman
Copy link
Contributor

@zeman zeman commented Sep 7, 2018

Release 3.1 updated the threshold from 0.75 to 0.9 for green in the report but the score legend wasn't updated.

Very small update to bring the score legend inline with the new threshold.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@zeman
Copy link
Contributor Author

zeman commented Sep 7, 2018

CLA signed.

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this!

lighthouse-core/report/html/templates.html Outdated Show resolved Hide resolved
@paulirish
Copy link
Member

mucho thanks, @zeman !!

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

- Green (good): 75-100.
- Red (poor score): 0-49
- Orange (average): 50-89
- Green (good): 90-100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@paulirish paulirish merged commit aa50f7d into GoogleChrome:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants