Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report(vulnerable-jslibs): tweak snyk link for highlighted matches #6096

Merged
merged 3 commits into from
Sep 24, 2018

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Sep 23, 2018

setting up snyk to do some nice highlighting on their side

before after
image image

pretty sweet.

cc @aviadatsnyk

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooooo, yes very nice!

@patrickhulce
Copy link
Collaborator

It is a bit hard to tell it's intentional though when basically everything is highlighted 😆 (from link in the tests now)

image

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛🔗 LGTM2

@brendankenny brendankenny merged commit fed4a88 into master Sep 24, 2018
@brendankenny brendankenny deleted the paulirish-patch-2 branch September 24, 2018 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants