Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 add back lighthouse-core scripts to npm package #6153

Merged
merged 4 commits into from
Oct 3, 2018

Conversation

r0mflip
Copy link
Contributor

@r0mflip r0mflip commented Oct 2, 2018

Issues: #6150

Summary
Solves #6150

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@r0mflip
Copy link
Contributor Author

r0mflip commented Oct 2, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. thanks for making the PR.
one idea though..

.npmignore Outdated
@@ -7,7 +7,6 @@ assets/
build/
coverage/

lighthouse-core/scripts/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

below a bit is this line:

!lighthouse-core/scripts/manual-chrome-launcher.js

can you add a direct refrence to the download-chrome sh right after it?

i'd rather do that than allowlist this whole folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good, thanks. Please verify.

@paulirish paulirish merged commit fbcb1e3 into GoogleChrome:master Oct 3, 2018
@r0mflip r0mflip deleted the add-back-scripts branch October 19, 2018 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants