Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli(docs): update docs for --output-path re: multiple output types #6339

Merged
merged 1 commit into from
Oct 18, 2018
Merged

cli(docs): update docs for --output-path re: multiple output types #6339

merged 1 commit into from
Oct 18, 2018

Conversation

connorjclark
Copy link
Collaborator

Fixes #6333.

brendankenny
brendankenny approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. This has been wrong for a long time :)

Does the text (with arrow and quotes) read well on the command line? If so, LGTM!

@connorjclark
Copy link
Collaborator Author

arrow LGTM:
image

patrickhulce
patrickhulce approved these changes Oct 18, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@brendankenny brendankenny merged commit 97d459b into master Oct 18, 2018
@brendankenny brendankenny deleted the issue-6333-output-paths-usage-docs branch October 18, 2018 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjclark @brendankenny @patrickhulce