tests: run node 10 on Travis #6361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Oct 22, 2018
| @@ -42,7 +42,7 @@ script: | |||
| - yarn test-viewer | |||
| - yarn test-lantern | |||
| - yarn i18n:checks | |||
| # _JAVA_OPTIONS is breaking parsing of compiler output. See #3338. | |||
| # _JAVA_OPTIONS is breaking parsing of `compile-devtools` output. See #3338. | |||
There was a problem hiding this comment.
changed this because I assumed this was old leftover closure stuff and originally deleted it, but #3338 is about a failure on yarn compile-devtools (which may eventually run again depending on the FIXME below)
brendankenny
changed the title
brendankenny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 10 is rapidly approaching LTS. We should be running our tests on Node 8 and 10, not 8 and 9 :)