Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: fix summary rendering in FF #6448

Merged
merged 1 commit into from
Nov 2, 2018
Merged

report: fix summary rendering in FF #6448

merged 1 commit into from
Nov 2, 2018

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Nov 1, 2018 •
edited
Loading

it looked like this:

image

oof

brendankenny
brendankenny approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

patrickhulce
patrickhulce reviewed Nov 1, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool cool, I had no idea summary's were styled as numbered lists either 😮

exterkamp
exterkamp approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 🦊 👍

@paulirish paulirish merged commit 541e0f0 into master Nov 2, 2018
@paulirish paulirish deleted the ffsummary branch November 2, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce left review comments

@exterkamp exterkamp exterkamp approved these changes

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulirish @brendankenny @patrickhulce @exterkamp