Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: increase protocol timeout to 30s #6531

Merged
merged 2 commits into from
Nov 13, 2018
Merged

core: increase protocol timeout to 30s #6531

merged 2 commits into from
Nov 13, 2018

Conversation

connorjclark
Copy link
Collaborator

until we research what it really should be.

@connorjclark
core: increase protocol timeout to 30s
c23f4de 
until we research what it really should be.
@connorjclark connorjclark mentioned this pull request Nov 12, 2018
Merged
patrickhulce
patrickhulce suggested changes Nov 12, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we really need default network quiet back down to 5s can you fix that in here too :)

@connorjclark
Copy link
Collaborator Author

Done

brendankenny
brendankenny approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brendankenny brendankenny merged commit f1d6bdc into master Nov 13, 2018
@brendankenny brendankenny deleted the Hoten-patch-1 branch November 13, 2018 01:27
@brendankenny brendankenny mentioned this pull request Nov 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@connorjclark @paulirish @brendankenny @patrickhulce