Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: import <detail> polyfill as string, not Buffer #6607

Merged
merged 1 commit into from
Nov 19, 2018
Merged

report: import <detail> polyfill as string, not Buffer #6607

merged 1 commit into from
Nov 19, 2018

Conversation

brendankenny
Copy link
Member

Fixes viewer bundle size inflation introduced by #6593. The details-element-polyfill was accidentally being inlined as a base64-encoded Buffer and then having toString() called on it.

The string version is smaller, and we don't also need Buffer browserified in :)

@brendankenny
Copy link
Member Author 

$ bundlesize
 PASS  ./dist/extension/scripts/lighthouse-ext-bundle.js: 361.57kB < maxSize 520kB gzip 
 PASS  ./dist/viewer/src/viewer.js: 58.21kB < maxSize 65kB gzip

back where they should be.

@paulirish
Copy link
Member

budget success!!!

@paulirish paulirish merged commit c78e7bf into master Nov 19, 2018
@paulirish paulirish deleted the viewerbuff branch November 19, 2018 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brendankenny @paulirish