Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(tap-targets): remove lines with trailing whitespace #7105

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

exterkamp
Copy link
Member

Summary
2 lines in tap-targets were being browserified with trailing white space which fails on the LR bundler. So just remove those lines.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that the linter cares about trailing whitespace inside a string, though. Or does browserify turn this whole thing into an inlined string?

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, picky picky LR! 😆

@patrickhulce
Copy link
Collaborator

Side-note should these failures you're finding be reflected in our own test suite somewhere @exterkamp? Is that easy?

Feel bad we keep breakin' ya :(

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is dumb and is only going to break again, but ok linter :P

@brendankenny brendankenny changed the title core(tap-targets): remove lines with trailing whitespace misc(tap-targets): remove lines with trailing whitespace Jan 29, 2019
@brendankenny brendankenny merged commit 619db8a into master Jan 29, 2019
@brendankenny brendankenny deleted the remove-whitespace branch January 29, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants