Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: remove obsolete unused files #7476

Merged
merged 1 commit into from
Mar 12, 2019
Merged

misc: remove obsolete unused files #7476

merged 1 commit into from
Mar 12, 2019

Conversation

brendankenny
Copy link
Member

--all test coverage revealed some old files we don't use anywhere or have any tests for. Removing them.

In Memoriam:

  • pushed-requests.js - was a handy helper, but we ended up never using it and it will be easy to recreate if we ever need it
  • console-quieter.js - made devtools-frontend keep it quiet back when we imported it as a dependency when it really really wasn't made to be used as a dependency
  • empty-stub.js - used for require() shenanigans for environments where we knew we wouldn't be using certain dependencies but we didn't want require() to throw.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP 💀

@brendankenny brendankenny merged commit bec96a6 into master Mar 12, 2019
@brendankenny brendankenny deleted the old branch March 12, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants