Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: update collected i18n string #8158

Merged
merged 1 commit into from
Apr 10, 2019
Merged

misc: update collected i18n string #8158

merged 1 commit into from
Apr 10, 2019

Conversation

brendankenny
Copy link
Member

I overrode Travis for #7241 because some git branching was messing up yarn test-lantern, but I didn't notice on my last push that travis was also broken on yarn diff:sample-json. So...

😳😳

patrickhulce
patrickhulce approved these changes Apr 10, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least I'm absolved from feeling bad about forgetting to suggest changes! 😆

to quite as useful when you have to remember update sample json :(

@brendankenny brendankenny merged commit 45d6911 into master Apr 10, 2019
@brendankenny brendankenny deleted the unbreak branch April 10, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exterkamp exterkamp exterkamp approved these changes

@patrickhulce patrickhulce patrickhulce approved these changes

@wardpeet wardpeet wardpeet approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brendankenny @wardpeet @patrickhulce @exterkamp