Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: use border-box for psuedoelements #8528

Merged
merged 1 commit into from
Apr 23, 2019
Merged

report: use border-box for psuedoelements #8528

merged 1 commit into from
Apr 23, 2019

Conversation

patrickhulce
Copy link
Collaborator

Summary
Super minor fix for error state icon in metrics. It's not in our fixtures so here's the before/after.

Before
image

After
image

connorjclark
connorjclark approved these changes Apr 22, 2019
View reviewed changes
Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank ya

exterkamp
exterkamp approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM

brendankenny
brendankenny approved these changes Apr 23, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗳

@brendankenny brendankenny merged commit d816067 into master Apr 23, 2019
@brendankenny brendankenny deleted the metric_error_state_icon branch April 23, 2019 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exterkamp exterkamp exterkamp approved these changes

@connorjclark connorjclark connorjclark approved these changes

@brendankenny brendankenny brendankenny approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickhulce @brendankenny @connorjclark @exterkamp