report(redesign): order gauges - default, pwa, plugins #8529
Conversation
| defaultGauges.push(categoryGauge); | ||
| if (Util.isPluginCategory(category.id)) { | ||
| pluginGauges.push(categoryGauge); | ||
| } else if (renderer.renderScoreGauge === categoryRenderer.renderScoreGauge) { |
There was a problem hiding this comment.
this seems like an interesting way to tell, I guess the point is "do we render this gauge exactly like the others or does the gauge look different"?
There was a problem hiding this comment.
i 100% don't understand renderer.renderScoreGauge === categoryRenderer.renderScoreGauge.
There was a problem hiding this comment.
There was a problem hiding this comment.
if it's confusing, should keep the comment :) (or make it more informative!)
| // Group gauges that aren't default at the end of the header | ||
| if (renderer.renderScoreGauge === categoryRenderer.renderScoreGauge) { | ||
| defaultGauges.push(categoryGauge); | ||
| if (Util.isPluginCategory(category.id)) { |
| }); | ||
|
|
||
| assert.notEqual(-1, indexOfPwaGauge); | ||
| assert.notEqual(-1, indexOfPluginGauge); |
There was a problem hiding this comment.
seems like we also want to assert that indexOfPwaGauge is less than indexOfPluginGauge? and/or that they're the last two gauges?
| const defaultGauges = []; | ||
| const customGauges = []; | ||
| // Group gauges in this order: mainstream, pwa, plugins. | ||
| const mainstreamGauges = []; |
There was a problem hiding this comment.
can we still use "deault" (from default-config.js) or "core" for these?
| defaultGauges.push(categoryGauge); | ||
| if (Util.isPluginCategory(category.id)) { | ||
| pluginGauges.push(categoryGauge); | ||
| } else if (renderer.renderScoreGauge === categoryRenderer.renderScoreGauge) { |
There was a problem hiding this comment.
if it's confusing, should keep the comment :) (or make it more informative!)
connorjclark
changed the title
#8185