Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients(lr): revert Lightrider timings applied to NetworkRequests #8752

Merged
merged 3 commits into from
Apr 30, 2019

Conversation

exterkamp
Copy link
Member

This reverts commit ca1731a, which may have, slightly, kinda, messed up some performance data. Or whatever, I mean you never know.

@exterkamp exterkamp changed the title clients(lr): revert Lightrider timings to NetworkRequests clients(lr): revert Lightrider timings applied to NetworkRequests Apr 30, 2019
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #8752 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #8752     +/-   ##
=========================================
- Coverage   91.06%   90.97%   -0.1%     
=========================================
  Files         285      285             
  Lines        9712     9701     -11     
=========================================
- Hits         8844     8825     -19     
- Misses        868      876      +8
Flag Coverage Δ
#smoke 83.36% <ø> (+0.02%) ⬆️
#unit 89.2% <ø> (-0.03%) ⬇️
Impacted Files Coverage Δ
lighthouse-core/lib/network-request.js 99.38% <ø> (-0.04%) ⬇️
lighthouse-core/gather/connections/connection.js 73.33% <0%> (-6.67%) ⬇️
lighthouse-core/audits/user-timings.js 96% <0%> (-4%) ⬇️
...house-core/computed/metrics/lantern-speed-index.js 97.14% <0%> (-2.86%) ⬇️
lighthouse-core/gather/gather-runner.js 98.91% <0%> (-1.09%) ⬇️
lighthouse-core/lib/network-recorder.js 98.62% <0%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b7429...7882a46. Read the comment docs.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, LGTM

@brendankenny brendankenny merged commit d574377 into master Apr 30, 2019
@brendankenny brendankenny deleted the revert-timings branch April 30, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants