Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: chrome-launcher@0.10.7 #8781

Merged
merged 4 commits into from
May 2, 2019
Merged

deps: chrome-launcher@0.10.7 #8781

merged 4 commits into from
May 2, 2019

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented May 1, 2019 •
edited
Loading

patrickhulce
patrickhulce approved these changes May 1, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get outta here pesky @types!

brendankenny
brendankenny approved these changes May 1, 2019
View reviewed changes
package.json Outdated
@@ -132,7 +132,7 @@
},
"dependencies": {
"axe-core": "3.2.2",
"chrome-launcher": "^0.10.5",
"chrome-launcher": "^0.10.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will you also delete the resolutions entry down on L164-166? yay!

@brendankenny
Copy link
Member

is it possible the built js files aren't in 0.10.6? Or something else went wrong? Both CIs are still saying Cannot find module 'chrome-launcher'

@patrickhulce
Copy link
Collaborator

patrickhulce commented May 1, 2019 •
edited
Loading

hm yeah something looks wrong there, there's no dist/ folder in the npm tarball

image

@patrickhulce
Copy link
Collaborator

patrickhulce commented May 2, 2019 •
edited
Loading

heh @paulirish we were implicitly re-using the rimraf types from chrome-launcher in lighthouse-viewer :D

want to manually add @types/rimraf (and mkdirp perhaps)?

who knew a chrome-launcher bump would be so pesky

@brendankenny brendankenny changed the title deps: chrome-launcher@0.10.6 deps: chrome-launcher@0.10.7 May 2, 2019
@brendankenny
Copy link
Member

🔄🔄🔄

@brendankenny brendankenny merged commit 74614d6 into master May 2, 2019
@brendankenny brendankenny deleted the bumplauncher branch May 2, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulirish @brendankenny @patrickhulce