Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(performance-budget): add MP-FID as budget metric #8905

Merged
merged 1 commit into from
May 16, 2019
Merged

core(performance-budget): add MP-FID as budget metric #8905

merged 1 commit into from
May 16, 2019

Conversation

brendankenny
Copy link
Member

metric timing isn't actually budgetable yet, but we shouldn't tell folks that EIL will be budgetable.

patrickhulce
patrickhulce approved these changes May 10, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brendankenny brendankenny merged commit 4a74d17 into master May 16, 2019
@brendankenny brendankenny deleted the mpfidbudget branch May 16, 2019 19:21
paulirish pushed a commit that referenced this pull request May 28, 2019
@brendankenny @paulirish
core(performance-budget): add MP-FID as budget metric (#8905)
60dba87
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendankenny @paulirish @patrickhulce