Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: hide 3rd party filter checkbox if all rows are 3rd party #8966

Merged
merged 4 commits into from
May 17, 2019
Merged

report: hide 3rd party filter checkbox if all rows are 3rd party #8966

merged 4 commits into from
May 17, 2019

Conversation

jburger424
Copy link
Contributor

Related Issues/PRs
Resolves #8955

@jburger424 jburger424 changed the title Hide 3rd party filter checkbox if all rows are 3rd party. report(third party): hide 3rd party filter checkbox if all rows are 3rd party May 15, 2019
@patrickhulce patrickhulce changed the title report(third party): hide 3rd party filter checkbox if all rows are 3rd party report: hide 3rd party filter checkbox if all rows are 3rd party May 15, 2019
patrickhulce
patrickhulce approved these changes May 15, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @jburger424!

lighthouse-core/report/html/renderer/report-ui-features.js Outdated Show resolved Hide resolved
lighthouse-core/report/html/renderer/report-ui-features.js Outdated Show resolved Hide resolved
brendankenny
brendankenny reviewed May 16, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test to report-ui-features-test.js? It should hopefully only need picking another audit from the sample results in that beforeAll section and make them all third party

@brendankenny
Copy link
Member

and actually, that "no filter" test is just for thirdPartyFilterAuditExclusions, not for if there are no third party URLs, so if it's easy would you mind adding that as well? 🥇 🥇

brendankenny
brendankenny approved these changes May 17, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking this!

@brendankenny brendankenny merged commit be31c63 into GoogleChrome:master May 17, 2019
paulirish pushed a commit that referenced this pull request May 28, 2019
@jburger424 @paulirish
report: hide 3rd party filter checkbox if all rows are 3rd party (#8966)
28c682f
@connorjclark connorjclark mentioned this pull request May 31, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Show 3rd-party resources" checkbox should be hidden when all resources are 3rd party.
3 participants
@jburger424 @brendankenny @patrickhulce