-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): related project: lighthouse-jest-example #9172
docs(readme): related project: lighthouse-jest-example #9172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really neat project thanks for sharing @justinribeiro! updated for 2019 style for sure 😎
would you mind moving this line up above lambda? we're trying to keep this alphabetical this time around :)
"2019 style", I feel trendy now. 😃 Updated for alphabetical. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % nits
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
This is an example using lighthouse+jest to test not just a single network profile, but also to use puppeteer/cdp network emulation in conjunction with WPT network profiles to give more testing surface. I've been using this example the last six or so months to help some orgs get into the webperf side and move them to CI-based lighthouse (small steps).