Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): related project: lighthouse-jest-example #9172

Merged
merged 3 commits into from
Jun 12, 2019

Conversation

justinribeiro
Copy link
Contributor

This is an example using lighthouse+jest to test not just a single network profile, but also to use puppeteer/cdp network emulation in conjunction with WPT network profiles to give more testing surface. I've been using this example the last six or so months to help some orgs get into the webperf side and move them to CI-based lighthouse (small steps).

image

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really neat project thanks for sharing @justinribeiro! updated for 2019 style for sure 😎

would you mind moving this line up above lambda? we're trying to keep this alphabetical this time around :)

@justinribeiro
Copy link
Contributor Author

"2019 style", I feel trendy now. 😃

Updated for alphabetical.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits

readme.md Outdated Show resolved Hide resolved
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants