Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo #9411

Merged
merged 2 commits into from Jul 19, 2019
Merged

docs: fix typo #9411

merged 2 commits into from Jul 19, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 18, 2019

Summary

This PR fixes some typos as the followings:

  • were -> was (docs/understanding-results.md)
  • mask -> masks (docs/variability.md)
  • failing audit -> failing audit (docs/architecture.md)

Related Issues/PRs

N/A

@ghost ghost requested a review from paulirish as a code owner July 18, 2019 23:04
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all but one of these changes LGTM.

thanks!

readme.md Outdated Show resolved Hide resolved
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for finding these!

@patrickhulce patrickhulce dismissed connorjclark’s stale review July 19, 2019 14:28

addressed by author :)

@patrickhulce patrickhulce merged commit d2ec9ff into GoogleChrome:master Jul 19, 2019
Gudahtt pushed a commit to Gudahtt/lighthouse that referenced this pull request Jul 19, 2019
@ghost ghost deleted the docs-typo branch July 20, 2019 08:45
paulirish pushed a commit that referenced this pull request Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants