Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(seo): support portuguese in link-text audit #9446

Merged
merged 3 commits into from
Jul 30, 2019
Merged

core(seo): support portuguese in link-text audit #9446

merged 3 commits into from
Jul 30, 2019

Conversation

letanure
Copy link
Contributor

@letanure letanure commented Jul 24, 2019

Summary

Add Portuguese translations for the Links Do Not Have Descriptive Text

Note that in Portuguese there is this symbol: ´. People forget to write it so we may take into account these errors, let me know your opinion.

feature, since adding new words to the test

Portuguese is one of the top 10 languages used on the internet ref1

translated words for non-portuguese speakers

Related Issues/PRs

#7547 #5322

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@letanure letanure changed the title core(seo): support spanish in link-text audit core(seo): support portuguese in link-text audit Jul 24, 2019
@letanure
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much @letanure!! 🇵🇹

I think at this point we've rejected a formal process here, so the Google Translations are good enough for me :) 👍

lighthouse-core/audits/seo/link-text.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants