Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: retry cli tests up to 3 times in appveyor #9512

Merged
merged 1 commit into from
Aug 5, 2019
Merged

misc: retry cli tests up to 3 times in appveyor #9512

merged 1 commit into from
Aug 5, 2019

Conversation

patrickhulce
Copy link
Collaborator

Summary
Just trying something out, appveyor builds have started failing ~50% of the time lately.

brendankenny
brendankenny approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the trying out looked good to you :)

@patrickhulce
Copy link
Collaborator Author

It does, even if it's kinda scary that the first try already took the 3 attempts :)

@patrickhulce patrickhulce merged commit 83d63bc into master Aug 5, 2019
@patrickhulce patrickhulce deleted the deflake_appveyor branch August 5, 2019 21:04
@connorjclark
Copy link
Collaborator

i'm guessing we bump this to 4 one day :)

paulirish pushed a commit that referenced this pull request Nov 6, 2019
@patrickhulce @paulirish
misc: retry cli tests up to 3 times in appveyor (#9512)
be8aaf8
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickhulce @connorjclark @brendankenny @googlebot