Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: update favicon #9688

Merged
merged 4 commits into from
Sep 18, 2019
Merged

report: update favicon #9688

merged 4 commits into from
Sep 18, 2019

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Sep 17, 2019

image

This favicon is great because it's lower detailed and kinda-monochrome, so it is much clearer than the current favicon.

This is also the image we will use for the extension browser action image.

Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sparks joy ✨

@brendankenny
Copy link
Member

Is it kind of blurry or just the screenshot? Is there a crisper version we could generate at that size @yuinchien?

@brendankenny
Copy link
Member

@connorjclark @brendankenny I provided the asset size according to connor's request, if it's still not crisp let me know, i can export 2x and try.

I could totally be wrong, I'm only basing this on the screenshot. Here it is as a png:
little-lighthouse

Maybe we'd need to get into pixel art to get it crisper and we can consider that another time

@paulirish
Copy link
Member

paulirish commented Sep 17, 2019

Here it is as a png:

maybe GH messed with your upload, but that png didnt match what i saw when i viewed the data uri directly.

here's that but zoomed without smoothing:

image

note the opacity!

pixel-wise.. seems good.

@brendankenny
Copy link
Member

maybe it's a retina thing, then? I don't know how scaling works for favicons, though.

favicons

@yuinchien
Copy link
Collaborator

Seems like we need to export 2x asset for retina. Will make sure to deliver them first thing tomorrow.

@connorjclark
Copy link
Collaborator Author

yeah looks like 32x32 is a safe bet

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice icon.

lighthouse-viewer/app/index.html Outdated Show resolved Hide resolved
lighthouse-core/report/html/report-template.html Outdated Show resolved Hide resolved
Co-Authored-By: Paul Irish <paulirish@google.com>
@vercel vercel bot temporarily deployed to staging September 18, 2019 21:37 Inactive
Co-Authored-By: Paul Irish <paulirish@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants