core(driver): fix error handling for Runtime.evaluate #9831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Oct 12, 2019
| // Also occurs when the expression is not valid JavaScript. | ||
| const errorMessage = response.exceptionDetails.exception ? | ||
| response.exceptionDetails.exception.description : | ||
| response.exceptionDetails.text; |
There was a problem hiding this comment.
i'm not confident enough in the protocol to know if we can remove response.exceptionDetails.text so i keep it as fallback
There was a problem hiding this comment.
puppeteer has a more robust version https://github.com/GoogleChrome/puppeteer/blob/e0c8d46af1ce2c063778b66aa29c4c00ab8aeba5/lib/helper.js#L47-L60
but i'm happy with the improvement you've made here
paulirish
reviewed
Oct 12, 2019
There was a problem hiding this comment.
fwiw here's one of these payloads
{ result:
{ type: 'object',
subtype: 'error',
className: 'ReferenceError',
description: 'ReferenceError: chrome is not defined\n at <anonymous>:1:1',
objectId: '{"injectedScriptId":1,"id":1}' },
exceptionDetails:
{ exceptionId: 1,
text: 'Uncaught',
lineNumber: 0,
columnNumber: 0,
scriptId: '30',
exception:
{ type: 'object',
subtype: 'error',
className: 'ReferenceError',
description: 'ReferenceError: chrome is not defined\n at <anonymous>:1:1',
objectId: '{"injectedScriptId":1,"id":2}' } } }
paulirish
approved these changes
Oct 12, 2019
| // Also occurs when the expression is not valid JavaScript. | ||
| const errorMessage = response.exceptionDetails.exception ? | ||
| response.exceptionDetails.exception.description : | ||
| response.exceptionDetails.text; |
There was a problem hiding this comment.
puppeteer has a more robust version https://github.com/GoogleChrome/puppeteer/blob/e0c8d46af1ce2c063778b66aa29c4c00ab8aeba5/lib/helper.js#L47-L60
but i'm happy with the improvement you've made here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #9605 / #9650
repro by messing up the expression:
before:
after: