Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Downscope OAuth2 token included in ephemeral certificate #1450

Merged
merged 6 commits into from
Oct 6, 2022

Conversation

enocom
Copy link
Member

@enocom enocom commented Sep 30, 2022

In the past, when using Auto IAM AuthN, the token embedded into the ephemeral certificate would have a broad scope. This commit ensures that in most cases, the embeddeded token has only a sqlservice.login scope.

When users provide a token to launch the proxy, the proxy will use that token with whatever scopes are attached.

Fixes #1446.

In the past, when using Auto IAM AuthN, the token embedded into the
ephemeral certificate would have a broad scope. This commit ensures that
in most cases, the embeddeded token has only a sqlservice.login scope.

When users provide a token to launch the proxy, the proxy will use that
token with whatever scopes are attached.

Fixes #1446.
@enocom enocom requested a review from a team September 30, 2022 15:35
@enocom enocom changed the title Token scope feat: login tokens have a limited scope Sep 30, 2022
@enocom enocom changed the title feat: login tokens have a limited scope feat: Downscope OAuth2 token included in ephemeral certificate Sep 30, 2022
Copy link
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enocom enocom added the tests: run Label to trigger Github Action tests. label Oct 5, 2022
@github-actions github-actions bot removed the tests: run Label to trigger Github Action tests. label Oct 5, 2022
@enocom enocom enabled auto-merge (squash) October 6, 2022 18:03
@enocom enocom merged commit 7557a35 into v1 Oct 6, 2022
@enocom enocom deleted the token-scope branch October 6, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants