Skip to content

Commit

Permalink
logging-winston: make winston a peerDependency (#2453)
Browse files Browse the repository at this point in the history
Users of this library need to depend on winston directly. There are
scenarios where the user, or other libraries may depend on a semver
incompatible version of winston. Not only does it end up installing an
unnecessary copy of winston; it may also lead to our transport not
being visible in `winston.transports` that the user has visibility to.
  • Loading branch information
ofrobots authored and stephenplusplus committed Jul 13, 2017
1 parent 193e747 commit 4b5158e
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions packages/logging-winston/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,15 @@
"@google-cloud/logging": "^1.0.0",
"extend": "^3.0.0",
"is": "^3.2.0",
"lodash.mapvalues": "^4.6.0",
"winston": "^2.2.0"
"lodash.mapvalues": "^4.6.0"
},
"peerDependencies": {
"winston": "^2.x"
},
"devDependencies": {
"mocha": "^3.2.0",
"proxyquire": "^1.7.10"
"proxyquire": "^1.7.10",
"winston": "^2.2.0"
},
"scripts": {
"publish-module": "node ../../scripts/publish.js logging-winston",
Expand Down

0 comments on commit 4b5158e

Please sign in to comment.