Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all tests passing with --incompatible_disable_legacy_cc_provider for Bazel 0.25.0 #7

Closed
oquenchil opened this issue Mar 5, 2019 · 2 comments

Comments

@oquenchil
Copy link

It seems that Cloud Robotics Core will start breaking with the next Bazel release 0.25 because of an incompatible change (bazelbuild/bazel#7036)

ERROR: /home/bazel/.cache/bazel/_bazel_bazel/c6d20798bfe5b1f78a6158f10ba87246/external/org_golang_x_sys/unix/BUILD.bazel:3:1: in libs attribute of _cgo_collect_info rule @org_golang_x_sys//unix:go_default_library%windows_386%cgo_info: '@org_golang_x_sys//unix:go_default_library%windows_386%cgo_c_lib' does not have mandatory providers: 'cc'. Since this rule was created by the macro 'go_library_macro', the error might have been caused by the macro implementation in /home/bazel/.cache/bazel/_bazel_bazel/c6d20798bfe5b1f78a6158f10ba87246/external/io_bazel_rules_go/go/private/rules/cgo.bzl:694:16

I don't see any errors for rules_go, so it could be that Cloud Robotics Core is using an old version of rules_go?

@drigz
Copy link
Contributor

drigz commented Mar 5, 2019

I think this was fixed by c103df8. I guess this was reported by a Buildkite run; do you know which version it used?

@oquenchil
Copy link
Author

Yes, it doesn't show up anymore. It must have been right before that update. Thank you Rodrigo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants