-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider removing mandatory color stop in interval [0,1] #148
Comments
Revise to just there must be at least one color stop? |
Right. Zero stops is undefined. One stop gives a solid fill and it doesn't matter where the stop position is. Two or more stops, the stop positions matter (but still need not be in the 0 to 1 range). |
@drott Current wording in 5.7.11.1.2.1 is:
Should the requirement to be within [0,1] be removed? |
@drott We need to close on this. |
Is clear what needs to be done. |
Conceptually, it doesn't matter. But is there any issue with what existing libraries can handle? |
@PeterConstable existing libraries for colr v0? Colr v1 isn't finished speccing, so any existing colr v1 libraries should reasonably be expected to support whatever the spec finally says, imo |
But we were trying to accommodate (to some extent) existing graphics libraries. (Sorry, that's what I meant, not colr v1 libraries.) |
Either do some reasoning yourself, or accept that the rest of us have done that. This pattern of behavior of yours is what I have been objecting to since last year:
I'm not going to accept and tolerate that behavior. If you have suggestions, you discuss it with others, on github, like the rest of us do. Only if there was consensus, you write them down. Moreover, when I propose things like self-contained offsets, which solve REAL problems (eg. #293, #11), you just ignore. You didn't understand why this pattern is problematic a year ago. And looks like you still don't. So yes, I can explain to you why virtual gids are a problem. But I won't, because I do not condone and won't tolerate the above behavior. |
@behdad Your prejudice toward me is getting in the way of reason. The requirement to have at least one color stop defined within the range [0,1] was in the initial document commited by Dominik; I have left that as stated until now. Dominik raised the question in December; he, Rod, Cosimo and I discussed various aspects of the gradient definitions along the way and agreed on various changes, but we never closed on this issue. I have not changed anything; I have not created roadblocks; I am trying to discuss this now on GitHub as you suggest should be done, except when I do you object. This is not reasonable conduct. |
Psychological safety is hard to achieve when we are forced by external factors to eschew face to face interaction. It will make everyones life easier if we assume good intent in others. Taking virtual gids as an example, I didn't find the harm of them obvious either. Further, one of the things I've always deeply appreciated from the font community in general and @behdad in particular is courtesy around noob questions. It feels OK to not know things, to make basic mistakes, and that makes it dramatically easier to learn. I'd hate to see us lose that. |
Ah yes, right - so is what you are asking, is anyone aware of any graphics library that requires that there is a color stop defined between 0 and 1? |
Skia's and Cairo's color line semantics are quite different from what COLRv1 prescribes. In blackrenderer we calculate new points so we can convert COLRv1 to what the graphics libraries need. This recalculation of points does not require any color stops to be within [0, 1] in the COLRv1 model, even though the graphics libraries want everything to be within [0, 1]. So therefore, the [0, 1] restriction in "A color line is defined with at least one color stop within the interval [0, 1]" is IMO unnecessary. |
That's the wrong question to ask. If any graphics library has such limitations, implementation of COLRv1 on top of that library needs to add extrapolated points as necessary. |
I don't think we need to enforce that there is a color stop defined between 0 and 1.
The text was updated successfully, but these errors were encountered: