Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete list of profiles #15

Closed
felipesanches opened this issue Mar 15, 2021 · 5 comments
Closed

Incomplete list of profiles #15

felipesanches opened this issue Mar 15, 2021 · 5 comments

Comments

@felipesanches
Copy link
Member

The list of profiles is hardcoded, which means it will (from time to time) be incomplete as it is right now (it lacks universal, for instance):
Captura de Tela 2021-03-15 às 17 20 29

There should be some way to auto-populate this drop-down with all available profiles

@felipesanches
Copy link
Member Author

And universal should be the default one!

@felipesanches
Copy link
Member Author

but it should also remember the user's last choice

@simoncozens
Copy link
Collaborator

There should be some way to auto-populate this drop-down with all available profiles

So first we need to solve fonttools/fontbakery#3188 so that when we walk the fontbakery.profiles namespace, we know which are "top-level profiles" that should appear in the list and which are just collections of checks.

@graphicore
Copy link
Collaborator

graphicore commented Mar 19, 2021

Do something simple. Put a module name TOPLEVEL = True in there and use it, or use a naming convention like _{profilename}.py for lower levels.

@simoncozens
Copy link
Collaborator

This is fixed in eacbbdc and fc21ce8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants