Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An observation: GlyphData.xml ignored for 11 cases/sources #245

Closed
marekjez86 opened this issue Jan 31, 2017 · 6 comments · Fixed by #1016
Closed

An observation: GlyphData.xml ignored for 11 cases/sources #245

marekjez86 opened this issue Jan 31, 2017 · 6 comments · Fixed by #1016

Comments

@marekjez86
Copy link
Contributor

marekjez86 commented Jan 31, 2017

In the past, a custom GlyphData.xml was delivered along with Glyphs source files. The following deliveries have had GlyphData.xml included before, which we ignore (and not even store in noto-source):
NotoSansArabic
NotoSansArabicUI
NotoSansCherokee
NotoSansGeorgian
NotoSansHebrew
NotoSansMyanmar
NotoSansMyanmarUI
NotoSerifArmenian
NotoSerifGeorgian
NotoSerifHebrew
NotoSerifMyanmar

@brawer
Copy link
Contributor

brawer commented Jan 31, 2017

To simplify the workflow and reduce the chance of things going wrong, could you make the Glyphs sources self-contained? According to googlefonts/glyphsLib#12, “Glyphs can store production names in the .glyphs file now”. Not sure how to do this, but it’s surely explained somewhere on the forums.

@brawer
Copy link
Contributor

brawer commented Jan 31, 2017

We could also compare the content of those custom files against the XML files in https://github.com/schriftgestalt/GlyphsInfo/, and resolve any differences. @marekjez86, could you find somebody locally who could write a little script? Shouldn’t take more than a few hours.

@marekjez86
Copy link
Contributor Author

@brawer : I have placed the list for the record. For a while, MTI has been producing only standalone sources and they'll investigate what might be done here. I just didn't want to lose the track of the names of the sources that we need to deal with.

@brawer
Copy link
Contributor

brawer commented Feb 20, 2017

Has anyone done this comparison? If not: @marekjez86, can you send me those GlyphData.xml files?

@marekjez86
Copy link
Contributor Author

marekjez86 commented Feb 20, 2017 via email

@punchcutter
Copy link

punchcutter commented Mar 13, 2017

The files above are all the exact same GlyphData.xml. And they aren't used at all in these particular Glyphs files. There's no reason for these GlyphData.xml to be there because nothing related to these scripts is in the file. The only one with related info is Arabic, but it almost all matches what's in the Glyphs source file. The only thing I see from the above is that NotoSansArabicUI has one discrepancy:

Glyph production name for fehDotbelow-ar is uni06A2. GlyphData.xml expects uni06A3.
Glyph unicode for fehDotbelow-ar is 06A2. GlyphData.xml expects 06A3.

NotoSansArabic matches the GlyphData.xml. Also in this case it matches the default GlyphData.xml. I also checked Myanmar and Thai and I see nothing used in a custom GlyphData.xml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants