Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export flag: subsetter does not account for .notdef in OT binary #443

Closed
madig opened this issue Jun 14, 2018 · 2 comments
Closed

Export flag: subsetter does not account for .notdef in OT binary #443

madig opened this issue Jun 14, 2018 · 2 comments

Comments

@madig
Copy link
Collaborator

madig commented Jun 14, 2018

https://github.com/googlei18n/fontmake/blob/master/Lib/fontmake/font_project.py#L441

This leads to glyphs not lining up:

old_name new_name
A .notdef
B A
C B
D C
E D
F E
G F
H G
I H
[...]
@madig
Copy link
Collaborator Author

madig commented Jun 14, 2018

Hm. So .notdef might be in the UFO, but not as the first glyph, so this needs special handling.

@anthrotype
Copy link
Member

ufo2ft forces .notdef to always be the first, so the output TTFont always has it as the first glyph. And if the font doesn't contain one, it inserts as stub glyph at that position.
There is no other sensible place for a glyph that is named ".notdef" (and of course has no codepoint assigned to it).
I believe Glyphs.app also does the same, if .notdef is present in the font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants