Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine glyphs from default master #603

Closed
madig opened this issue Nov 26, 2019 · 0 comments
Closed

Determine glyphs from default master #603

madig opened this issue Nov 26, 2019 · 0 comments
Labels
enhancement Instantiator Issues relating to generating static instances with the instantiator module.

Comments

@madig
Copy link
Collaborator

madig commented Nov 26, 2019

Cosimo chat log

fontmake instantiator collects the list of glyph_names by unioning the font.keys of all the masters
it should rather take the default_font.keys() only
also, in collect_glyph_masters it silently skips if a glyph_name is not in source_layer, without checking if that source_layer is the default, in which case it should blow away
if a non-default master has a glyph which the default doesn't have, then that glyph should be ignored by definition

@madig madig added enhancement Instantiator Issues relating to generating static instances with the instantiator module. labels Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Instantiator Issues relating to generating static instances with the instantiator module.
Projects
None yet
Development

No branches or pull requests

1 participant