Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editor] "Can’t edit glyph" dialog should be refined #591

Closed
justvanrossum opened this issue Jun 29, 2023 · 1 comment · Fixed by #626
Closed

[editor] "Can’t edit glyph" dialog should be refined #591

justvanrossum opened this issue Jun 29, 2023 · 1 comment · Fixed by #626
Assignees
Labels
user experience An issue with the user experience

Comments

@justvanrossum
Copy link
Collaborator

If the editor is not "at a source", and the user tries to move a point or component, we get a dialog that says:

Can’t edit glyph “<name-of-glyph>”
Location is not at a source.
                  (( Okay ))

What it should do instead is:

Can’t edit glyph “<name-of-glyph>”
Would you like to create a new source or navigate to the nearest source?
  ( Cancel )  ( Create new source )  (( Go to nearest source ))
@justvanrossum justvanrossum added the user experience An issue with the user experience label Jun 29, 2023
@justvanrossum justvanrossum moved this to 🏃 Sprint July in Fontra Project Jun 29, 2023
@fatih-erikli
Copy link
Collaborator

fatih-erikli commented Jul 6, 2023

I receive an error in console when I try to edit a glyph that it's source deleted.

varGlyph.sources[glyphController.sourceIndex] is undefined

@github-project-automation github-project-automation bot moved this from 🏃 Sprint July to ✅ Done in Fontra Project Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user experience An issue with the user experience
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants