This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
V2.138 Update #254
Merged
V2.138 Update #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@davelab6 has requested the webfonts have these bits set the Regular, google/fonts#710 (comment) This issue has been discussed in the past, googlefonts#142, googlefonts#188. There was no clear answer. I'm implementing this change so the webfonts better conform to our GF spec. This change will only affect the webfonts.
Since the Condensed now has Medium weights, the font total has increased from 18 to 20. The web fonts still have 18 because the Medium Condensed has not been hinted. The Black weight webfonts also have their fsSelection and fsType bits set back to Regular.
The dependency ufo2ft had a bug, googlefonts/ufo2ft#136 which set the flags of composite glyphs incorrectly. Solving the issue is rather complex. The previous implementation attempted to convert cubic splines to quadratic twice, once in fonts_to_quadratic and again in compileTTF. The conversion in compileTTF also reversed the contour direction. The composite flags were getting set incorrectly in compileTTF's conversion. To solve it, we disable conversion in compileTTF and enable the reverse_direction parameter in fonts_to_quadratic. Upgrading the ufo2ft dependency was not a viable option. The interfaces for some of its sub dependencies has changed.
Needed to update cu2qu dependency and its sub dependencies. Previous version didn't reverse every glyph contour correctly, https://github.com/googlei18n/cu2qu/blob/master/Lib/cu2qu/ufo.py#L169 Newer version will always reverse every contour.
|
Doug, would you please review? |
|
LGTM |
|
will release v2.138 ttf files? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update will fix issues #251 and google/fonts#738. #251 is a critical issue which was discovered by the Android team.
The v2.137 binaries were never tagged. I'm more than happy to upload these as well.
cc @davelab6