Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to cffsubr, deprecate then drop compreffor #464

Closed
khaledhosny opened this issue Feb 18, 2021 · 3 comments · Fixed by #465
Closed

Default to cffsubr, deprecate then drop compreffor #464

khaledhosny opened this issue Feb 18, 2021 · 3 comments · Fixed by #465

Comments

@khaledhosny
Copy link
Collaborator

Currently when building CFF 1 fonts compreffor is the default subroutinizer, but as we all know it is slow, really really show, and often produce larger tables than cffsubr.

I propose always defaulting to cffsubr, deprecate and eventually drop support for compreffor as I don’t see it serving much purpose anymore, but if you want to keep it for whatever reason, make it an optional dependency and and don’t install it by default.

@anthrotype
Copy link
Member

I wonder, is it the extra dependency or the fact you have to pass an extra compile option that bothers you? To me it kind of bothers me a little bit more that changing default would suddenly modify the built output of existing font projects as they update ufo2ft.

@khaledhosny
Copy link
Collaborator Author

Both, but having to remember to override the default option for each project I work on is the more pressing issue.

The change to output happens all the time, for example a few releases ago feaLib started compiling to different lookup types and subtables to efficiently store the data, that is a more potentially problematic change than the low level subroutines that should cause no functional difference whatsoever.

@anthrotype
Copy link
Member

ok, let's change default and keep it around for a while until it become a burden to maintain/update. PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants