Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Kubernetes 1.13 #1044

Closed
roberthbailey opened this issue Sep 6, 2019 · 10 comments · Fixed by #1178
Closed

Upgrade to Kubernetes 1.13 #1044

roberthbailey opened this issue Sep 6, 2019 · 10 comments · Fixed by #1178
Assignees
Labels
area/operations Installation, updating, metrics etc help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones
Milestone

Comments

@roberthbailey
Copy link
Member

1.14 is now generally available on the three major cloud providers, so following our guidance for supported versions, it's time to upgrade to 1.13.

Given that 1.0 is shipping next week, we should wait until after that to make the change.

@roberthbailey roberthbailey added the kind/feature New features for Agones label Sep 6, 2019
@heartrobotninja
Copy link
Contributor

heartrobotninja commented Sep 8, 2019

That is exciting because I can probably get rid of the special apimachinery directory.

@markmandel markmandel added area/operations Installation, updating, metrics etc help wanted We would love help on these issues. Please come help us! labels Sep 25, 2019
@roberthbailey
Copy link
Member Author

/assign

I'm planning to start working on this once the 1.1 release is finished.

@heartrobotninja
Copy link
Contributor

Let me know if you want any help. It might be worth having me handle the go lib portion since I should be able to get rid the modified apimachinery package.

@roberthbailey roberthbailey added this to the 1.2.0 milestone Oct 22, 2019
@roberthbailey
Copy link
Member Author

roberthbailey commented Nov 6, 2019

List of items to do for upgrading to 1.13 (this is an expanded version of the 1.12 issue):

  • Update e2e cluster to run against 1.13
    • Update deployment manage script
    • Recreate cluster with new scripts
  • Update prow cluster to use 1.13 (even though we aren't using it yet, we should keep it in sync)
    • Update deployment script
    • Recreate cluster with new scripts
  • Update the dev tooling to create 1.13 clusters
    • GKE
    • Minikube
    • Kind
    • Update kubectl
  • Update terraform submodules
    • GKE
    • Azure
  • Update documentation for creating clusters to 1.13
    • Usage requirements
    • GKE
    • Minikube
    • EKS
    • AKS
    • Helm documentation (currently still mentions 1.11 so we missed this one last time)
  • Update links to k8s documentation
    • examples/fleet.yaml
    • examples/fleetautoscaler.yaml
    • examples/gameserver.yaml
    • site/content/en/docs/Reference/fleet.md
    • site/content/en/docs/Reference/fleetautoscaler.md
    • site/content/en/docs/Reference/gameserver.md
  • Update to client-go 10.0 (based on compatibility matrix)

@markmandel
Copy link
Collaborator

Sounds like a good time to make a config param and/or shortcode in the Hugo site that specifies the supported version, so we only have to update one place.

@roberthbailey
Copy link
Member Author

@heartrobotninja - I'm getting started on this task now. If you are still interested in taking care of updating the client-go to 10.0 let me know and I'll focus on the other parts.

@roberthbailey
Copy link
Member Author

Sounds like a good time to make a config param and/or shortcode in the Hugo site that specifies the supported version, so we only have to update one place.

The documentation updates are in #1178 -- if you would rather try one of these ways to update the docs, send me some pointers and I'll see what I can do.

One thing to note is that while many of the places in the docs just reference the major/minor version of Kubernetes (e.g. "1.13") there are also places that use the patch version (e.g. "1.13.12") and we don't have a consistent patch version in all places; kind for example doesn't create node images for all releases, so it tends to have a slightly older patch version than minikube, etc.

@heartrobotninja
Copy link
Contributor

@roberthbailey Yep, I am still interested in handling the go client.

@roberthbailey
Copy link
Member Author

@heartrobotninja - any updates on this?

#1178 will finish off all of the checkboxes except for updating client-go.

@roberthbailey
Copy link
Member Author

#1189 updated client-go to 1.13.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operations Installation, updating, metrics etc help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants