Cannot Use Agones SDK Image on Windows 2022 Node Due to Missing os.version in Docker Manifest

[kangjk1017]

What happened:
The Agones SDK image cannot be used on Windows 2022 nodes. This issue occurs consistently across all versions starting from 1.40. The root cause appears to be the absence of the os.version field in the Docker image manifest. Consequently, the image is always pulled as if it were for Windows 2019, regardless of whether the actual node OS is Windows 2022 or Windows 2019.
https://console.cloud.google.com/artifacts/docker/agones-images/us/release/agones-sdk/sha256:3684e3e93891c8faf6a6e69aad2f86986011ee0596d26c3b84499e500b6bbade;tab=manifest

What you expected to happen:
The Agones SDK Docker image should recognize and be compatible with the actual OS version of the node, whether it is Windows 2022 or Windows 2019. The os.version field should be present in the Docker image manifest to ensure the correct image is pulled according to the node's OS.

How to reproduce it (as minimally and precisely as possible):
Attempt to deploy the Agones SDK Docker image on a Windows 2022 node.

Anything else we need to know?:
This issue is not limited to the Agones SDK image; it is likely to affect other Agones Docker images as well.

Environment:

• Agones version: 1.41
• Kubernetes version (use kubectl version): 1.29
• Cloud provider or hardware configuration: aks windows2022 node
• Install method (yaml/helm): helm
• Troubleshooting guide log(s): none
• Others: none

[markmandel]

Ooh weird!

A couple of potential thoughts:

1. We did move all image building to Cloud Build - there may be an issue with the older Docker server version they run (we would need to run that back to the Cloud Build team I think)
2. we also shifted to using docker buildx to create the manifest (line below). I wonder if that also caused issue with Cloud Build being an older Docker server version.

agones/build/Makefile

Line 714 in a27aeab

docker buildx imagetools create --tag $(sidecar_tag) $(push_sidecar_manifest)

[markmandel]

Another quick thought, not sure if it will solve the issue, but in gcr.io/cloud-builders/docker there is a 24.0.9 tag -- maybe there is a bug fix in there. Might be worth upgrading and finding out.

e.g.:

https://github.com/googleforgames/agones/blob/main/build/release/post_cloudbuild.yaml#L61 (although it would need to be changed across the whole code base)

[igooch]

Adding a note that as a workaround you should be able to use the image tag for {$VERSION}-windows_amd64-ltsc2022.

As Mark noted here there's a helm variable agones.image.tag to set the image tag.

[kangjk1017]

@igooch

Adding a note that as a workaround you should be able to use the image tag for {$VERSION}-windows_amd64-ltsc2022.

As Mark noted here there's a helm variable agones.image.tag to set the image tag.

As mention in #3979 (comment), I'm using Windows and Linux both for serving games. So if I set agones.image.sdk.tag to {$VERSION}-windows_amd64-ltsc2022, I cannot serve linux game servers.

https://console.cloud.google.com/artifacts/docker/agones-images/us/release/agones-sdk/sha256:9edd7270b94fdb6a9b09e5d1dc9a8fb2c0e0fea5742ee517b0d5de9f150935f6;tab=manifest?inv=1&invt=Abljgg
I checked version 1.45.0 today, and it seems to have the same issue.