Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Themeing] Watch for solution with Typescript prop allowable types for material-ui #132

Open
devYaoYH opened this issue Jun 26, 2020 · 1 comment
Open

[Themeing] Watch for solution with Typescript prop allowable types for material-ui #132

devYaoYH opened this issue Jun 26, 2020 · 1 comment
Labels
wontfix This will not be worked on

Comments

@devYaoYH
Copy link
Collaborator

Referencing issue: mui/material-ui#15573 here. Currently, we only have access to the default 13 variants in Typography using material-ui custom theme options. Definitely helpful for us to add custom options but not yet possible without Typescript complaining...
@devYaoYH
Copy link
Collaborator Author

devYaoYH commented Jul 2, 2020

Currently adopted workaround (also used for color themeing):

<MuiThemeProvider theme={altTheme}>
  <ComponentToStyle />
</MuiThemeProvider>

Declare many themes with this limited set of names and provide them at different points around elements needing additional customization, otherwise, an overall AppTheme is applied.

@devYaoYH devYaoYH added the wontfix This will not be worked on label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devYaoYH