Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: metric ScaleBar text not rendering correctly (#527) #563

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: metric ScaleBar text not rendering correctly (#527) #563

merged 1 commit into from
May 3, 2024

Conversation

dkhawk
Copy link
Collaborator

@dkhawk dkhawk commented May 2, 2024 •
edited by kikoso
Loading

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #527

@dkhawk dkhawk self-assigned this May 2, 2024
@dkhawk dkhawk requested a review from kikoso May 2, 2024 17:22
kikoso
kikoso approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@kikoso kikoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkhawk dkhawk merged commit 5c1cb5d into main May 3, 2024
9 of 11 checks passed
@dkhawk dkhawk deleted the dkhawk/fix-scalebar-metric-text branch May 3, 2024 18:17
googlemaps-bot pushed a commit that referenced this pull request May 3, 2024
@semantic-release-bot
chore(release): 4.4.2 [skip ci]
70f0cc3 
## [4.4.2](v4.4.1...v4.4.2) (2024-05-03)

### Bug Fixes

* metric ScaleBar text not rendering correctly ([#527](#527)) ([#563](#563)) ([5c1cb5d](5c1cb5d))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikoso kikoso kikoso approved these changes

Assignees

@dkhawk dkhawk

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScaleBar not showing meters value when using Compose BOM 2024 versions
3 participants
@dkhawk @googlemaps-bot @kikoso