feat!: view callback and layout functionality improvements #239
Conversation
| catalystInstance.callFunction(Constants.NAV_JAVASCRIPT_FLAG, "onTurnByTurn", params); | ||
| WritableNativeArray params = new WritableNativeArray(); | ||
| params.pushMap(map); | ||
| catalystInstance.callFunction(Constants.NAV_JAVASCRIPT_FLAG, "onTurnByTurn", params); |
There was a problem hiding this comment.
Nit: For future PRs, can we please separate changes that are meant to be mere formatting/styling changes? This will make it easier for reviewers to focus on the functional changes
There was a problem hiding this comment.
Yes, the project currently lacks formatting configuration, and as I locally have autoformatting, missed these changes. Once the formatting setup is complete and integrated into CI and lefthook linting, these formatting commits should disappear.
In the meantime, you can Hide whitespace changes in the GitHub review to focus on meaningful differences.
There was a problem hiding this comment.
Removed formatting changes on this file for easier review.
There was a problem hiding this comment.
To avoid these in future, I added forced formatting to the repo for future PR's in separe PR visible here: #240
android/src/main/java/com/google/android/react/navsdk/NavViewFragment.java
Outdated
Show resolved
Hide resolved
android/src/main/java/com/google/android/react/navsdk/NavViewFragment.java
Outdated
Show resolved
Hide resolved
|
Nit: For future PRs that aren't too critical to get out, is it possible to stat incrementally adding unit test coverage along with our changes? |
|
This is a great improvement, thanks Joonas! |
Most definetely yes. |
jokerttu
force-pushed
the
feat/improve-view-props-handling
branch
from
b3c2fe7 to
7322cc0
Compare
jokerttu
force-pushed
the
feat/improve-view-props-handling
branch
from
7322cc0 to
a416e11
Compare
jokerttu
changed the title
Fixes the
NavigationViewcallback registration issue when using multiple view instances.Resolves navigation view scaling issues by removing the mandatory
heightandwidthproperties and adding support for an optionalstyleproperty (breaking change). This allows developers to use flex or width/height parameters with percentage values.Fixes #28
Fixes #192
Fixes #233
Partially fixes #235
BREAKING CHANGE: The
heightandwidthproperties have been removed fromNavigationViewin favor of an optionalstyleproperty.